News for hackers. Stuff that matters.
Re:Ask HN: What tone to use in code review suggestions? by fossuser on Monday June 27, 2022 @01:47PM (#31898060)
+1 the reasoning is the entire point and all of these examples are good.

Just telling people to make changes without telling why doesn't teach them anything - especially when sometimes what's being requested isn't actually better (or is at least subjective).

Re:Ask HN: What tone to use in code review suggestions? by convolvatron on Monday June 27, 2022 @06:08PM (#31901492)
my rule is to weigh whether or not its worth making a comment very carefully. nothing without a clear justification. never say 'I would have done it this other way' - unless its a good friend who you often discuss style issues with. comment on things that you feel would make a substantial difference on schedule, maintainability, or function - and provide a clear reasoning with which to argue against.

wasting your peers time trying to enforce your style isn't just non-productive, it sours everyone on the whole exercise.