News for hackers. Stuff that matters.
Re:Ask HN: What tone to use in code review suggestions? by graftak on Monday June 27, 2022 @01:34PM (#31897872)
To me those questions could come off as condescending. I say could because I wouldn’t think that’s your intent, but the tone is there.
Re:Ask HN: What tone to use in code review suggestions? by kqr on Monday June 27, 2022 @03:28PM (#31899580)
That depends entirely on whether you add the question as a formality or if you are genuinely interested in why the other person might disagree.
Re:Ask HN: What tone to use in code review suggestions? by graftak on Tuesday June 28, 2022 @03:42AM (#31905199)
To me ’…don’t you agree?’ is the sort of rhetoric that parents use to make their kids internalise their beliefs.

If someone disagrees I expect them to speak up, if they’re not so inclined I’m interested to know why, so we can address/resolve that and move on.

Re:Ask HN: What tone to use in code review suggestions? by Kaze404 on Wednesday June 29, 2022 @01:02AM (#31916657)
The comment says "do you agree?", not "don't you agree?". I agree that the latter sounds condescending, but the former sounds reasonable to me.