News for hackers. Stuff that matters.
Re:Ask HN: What tone to use in code review suggestions? by sebastien_b on Monday June 27, 2022 @01:25PM (#31897764)
Agree with adding additional reasoning, regardless of the actual tone.

I’ve received some feedback along the lines of “LOL Wut?” on a comment in code, which I really didn’t know how to take or respond to (suffice to say its meaning was vague, and generally unhelpful).

Re:Ask HN: What tone to use in code review suggestions? by dhzhzjsbevs on Tuesday June 28, 2022 @09:08AM (#31907194)
Sometimes you catch people in low energy or bad moods. It doesn't excuse the behaviour but try not to take it personal.

My trick is to write the wtf in pending review then go and look later in the day if it's still valid. Often I just needed to eat something and I'll be over it.

Re:Ask HN: What tone to use in code review suggestions? by redwolf22 on Tuesday June 28, 2022 @09:23AM (#31907365)
I would talk it out with the person. Such comments aren't helpful at all, unless the mistake made on that line is obvious.