Re:Introducing PyScript (summary of PyCon keynote)
by js2 on Thursday June 23, 2022 @10:28AM
(#31849570)
Use intermediate steps:
keyOf = itemgetter("myKey")
valueOf = itemgetter("myValue")
filtered = (item for item in myList if valueOf(item) > 5)
grouped = groupby(sorted(filtered, key=keyOf), keyOf)
result = {key: sum(valueOf(item) for item in group) for key, group in grouped}
Re:Introducing PyScript (summary of PyCon keynote)
by musicale on Thursday June 23, 2022 @01:21PM
(#31852285)
Could you save a line by replacing valueOf(item) with item.value?
Re:Introducing PyScript (summary of PyCon keynote)
by js2 on Thursday June 23, 2022 @01:52PM
(#31852745)
OP wrote the code as if the list items were dictionaries, so I just made that pythonic. If they are objects whose attributes we care about then we can get rid of the two getters altogether which are mostly there to make the code more legible but also remove duplication. You could also switch them to attrgetters.
Re:Introducing PyScript (summary of PyCon keynote)
by gigatexal on Thursday June 23, 2022 @10:35AM
(#31849678)
Ooh I like this. That’s about what I would do as well.
Re:Introducing PyScript (summary of PyCon keynote)
by dfinninger on Thursday June 23, 2022 @10:40AM
(#31849747)
Yeah that Python would not pass my code review. Rule of thumb is don’t nest list comprehensions, and if you have to try to keep it to two. Checkpoint the results info a variable. You aren’t supposed to chain like that in Python.
From https://docs.python.org/3/tutorial/datastructures.html#id2
> You might have noticed that methods like insert, remove or sort that only modify the list have no return value printed – they return the default None. [1] This is a design principle for all mutable data structures in Python.
> Footnotes > [1] Other languages may return the mutated object, which allows method chaining, such as d->insert("a")->remove("b")->sort();.
Re:Introducing PyScript (summary of PyCon keynote)
by jgalt212 on Thursday June 23, 2022 @09:36AM
(#31848925)
True that. That's why I prefer R, and its built-in pipes, when I'm working with relatively clean data.
Re:Introducing PyScript (summary of PyCon keynote)
by gigatexal on Thursday June 23, 2022 @08:40AM
(#31848203)
Yeah ... In that case I would write a function to return this result dict in a more imperative way in python -- but perhaps that's cuz i am not that great of an engineer/python dev. But what I can see is that the syntax of Kotlin (which I've never written) you've provided is a lot cleaner.
Take Kotlin:
In python: to me that's incomprehensible. You have to read it the wrong way, and it's not really clear what the intention behind each step is. Like, the filter is in the middle!