The illegal aspect only pertains to doing something like this and not paying relevant taxes. Companies have been providing their employees housing for hundreds of years. Trump Org was perfectly free to provide employees apartments, provided appropriate tax filings and payments were made.