That seems astonishingly thorough, as if it must have been targeted? The burglaries I've heard of locally just grab the most reachable items, especially car keys.
> GUARANTEED
The thing with giving it to an attorney is you would have an contract, and I would expect them to explain very clearly what liability they would have in the event of this kind of mistake. I would also expect them to be good at keeping paper secrets in boxes, that's a very traditional practice.
edit: I see other commenters shared this idea too.
In your house, and maybe with trusted friends, keep the instructions sheet with logins and a reference to the relevant password number. "To access my email account, username is [email protected] and use password #5122 from the password list".
Simple, and provably useless to an adversary unless they have both passwords (aside from knowing password length/format with one).
Having a safe at home is an option, but it needs to be mounted properly to prevent a burglar from being able to simply carry it out and try and access later.
At the end of the day, your best bet is to keep instructions on accessing your data (minus the actual code that is needed) somewhere it can easily be found by your family, and make sure that one or more family members have copies of the code but don't know the full details of where to use it without those instructions.
The "give it to an attorney" plan would also worry me, unless I knew exactly who/what/when/where/why/how access was controlled and GUARANTEED (after all, an attorney's system could break down as easily as any other).