Re:Flags Are a Code Smell (2014)
by ultrarunner on Sunday May 22, 2022 @04:47AM
(#31466151)
Then to the extent that “code smell” has become heard as “code stink” it is not useful as a descriptor. Then again, I suppose “maybe be careful with that pattern” isn’t quite the click-inducing thought leadership demanded in our present day.
> Then to the extent that “code smell” has become heard as “code stink” it is not useful as a descriptor.
It's a very appropriate descriptor. Think about it for a second. A smell all by itself is not a sign of a problem.
> Then again, I suppose “maybe be careful with that pattern” isn’t quite the click-inducing thought leadership demanded in our present day.
Your personal assertion does not make any sense. "Code smell" is a widely-established, age-old concept. The concept of a "code smell" even precedes the concept of a "click".
Your comment sounds like you didn't even read the submission. Here's, quite literally, the second paragraph:
> "In my opinion these are code smells. Smells don’t necessarily indicate actual issues, just patterns that are likely to be used incorrectly and thus warrants extra care."
You see, the author points out quite unambiguously that context is key.