News for hackers. Stuff that matters.
Re:The Code Review Pyramid by icedchai on Tuesday March 22, 2022 @10:22PM (#30774126)
If code is getting to the PR stage and doesn't compile, you have serious organizational problems.

In previous jobs, I have "reviewed" code that has clearly never been run (syntax error in a script) and it makes me question my own sanity.

Re:The Code Review Pyramid by Quarrelsome on Wednesday March 23, 2022 @07:54PM (#30785054)
Or breaks the build in an otherwise non-obvious fashion or fucks the installer?
Re:The Code Review Pyramid by icedchai on Wednesday March 23, 2022 @08:24PM (#30785211)
One of the first things I check on a PR is if it passed CI cleanly. If the build has failed (failing tests, build problems, whatever), I get annoyed I was even asked to look at it.