Re:The Code Review Pyramid
by icedchai on Wednesday March 23, 2022 @08:24PM
(#30785211)
One of the first things I check on a PR is if it passed CI cleanly. If the build has failed (failing tests, build problems, whatever), I get annoyed I was even asked to look at it.
In previous jobs, I have "reviewed" code that has clearly never been run (syntax error in a script) and it makes me question my own sanity.