The Code Review Pyramid

Re:The Code Review Pyramid by pc86 on Tuesday March 22, 2022 @11:24AM (#30767196)

This structure (especially the optionality of the second pass) is how you end up with perfectly readable code iterating over List<T> when a hash map would suffice and be orders of magnitude more performant.

Nobody can do it perfectly, but I think trying to keep personal nitpicks out of reviews as much as possible - ideally by codifying team nitpicks in automated formatting/.prettierrc/whatever - lets people focus on things that matter: what the code does and how it does it.

[ Parent | on HN ]

Re:The Code Review Pyramid by TheCoelacanth on Wednesday March 23, 2022 @12:19AM (#30774900)

In perfectly readable code, it's easy to notice performance problems.

In my experience, unreadable code is usually where the worst performance problems are, because that's where they are the hardest to find and fix.

You seem to be conflating readability with formatting, which is not what I mean by readability. Poor and inconsistent formatting adds some friction to reading, but it's a relatively minor part of readability.

[ Parent | on HN ]

Re:The Code Review Pyramid by watwut on Tuesday March 22, 2022 @02:21PM (#30769557)

Then again, that one is super easy to find and fix if it turns out to actually be problem.

[ Parent | on HN ]