Re:Code review decision fatigue
by benaduggan on Tuesday March 15, 2022 @09:06AM
(#30684729)
How do you deal with people who don't adhere to the process? It's all fine and good to require people to write tests, but often I catch bugs in their test code too.
Re:Code review decision fatigue
by swiftcoder on Tuesday March 15, 2022 @10:23AM
(#30685679)
That's the whole point of code review! If you find a logic bug in a test, your review is adding actual concrete value to the PR
Are your code reviews producing a bunch of design feedback? You probably should have design reviews long before a feature gets to the PR stage. Code reviews producing formatting feedback? That's the job of an opinionated auto-formatter (a la Go or Rust). Code reviews finding a lot of logic bugs? That's what automated tests and fuzzers are for...