Re:Pull Request File Tree Feedback
by iovrthoughtthis on Saturday March 12, 2022 @06:18AM
(#30650617)
i have no idea why we include these in code reviews tbh
[ Parent
| on HN ]
Not saying I review dependency locks as well as I should, but one reason to is to prevent supply chain attacks. E.g. making a typo that installs a malicious package. I recently saw a $60k beast of a machine with 64 cores get pwnd. We all wondered why “-bash” was burning 48 cores of CPU until I attached strace to it and we saw JSON RPC messages indicative of crypto mining. Everyone with access to the machine is trustworthy, but someone may have typo’d a pip install or something like that.