News for hackers. Stuff that matters.
Re:Ask HN: Do you pull and run code as part of code review? by nicoburns on Sunday March 06, 2022 @10:06AM (#30577994)
I wish there was a better workflow for this. We have code across ~10 repos at work, and I'm usually working on something else. So checking out somebody's code for pull requests is pretty disruptive. We generally consider "that the code runs" not to be part of code review, and have a separate testing phase before codes goes into production. Which works, but it definitely could be a smoother process.
Re:Ask HN: Do you pull and run code as part of code review? by codecurve on Sunday March 06, 2022 @10:08AM (#30578015)
Re:Ask HN: Do you pull and run code as part of code review? by nicoburns on Sunday March 06, 2022 @01:48PM (#30579959)
I have played with them before, but I haven't properly tried them for this. I can see it solves half the problem (being able to open something twice). But there's still a lot left to be solved:

1. I need to check out ~8 branches

2. I then need to reinstall all dependencies for those branches.

3. I then need to run those branches locally on a different set of ports to my standard dev environment to avoid clashes (or shutdown my main one temporarily)

4. If it involves the mobile app I may need to wait some time for a clean build

It's a lot of administrative overhead compared to what I tend to default to in most cases which is just merge the branch after reading through it and then test in our staging environment once CI has run.

Re:Ask HN: Do you pull and run code as part of code review? by dkns on Sunday March 06, 2022 @10:10AM (#30578026)
Have you tried using git worktree?