Re:Size is the best predictor of code quality
by berntb on Monday September 26, 2011 @03:34AM
(#3037957)
>>complex call graphs are even worse than complex code inside a function
Hear hear.
I have a problem specific to that, here. Some programmers follow the "no documentation should be needed, the code is obvious" dogma in a non-typed scripting language -- and you have to look many levels up in the call graph before you even find out about the damn function parameter's types... :-(
Re:Size is the best predictor of code quality
by dman on Monday September 26, 2011 @05:25AM
(#3038172)
Ideally you have tests which let you know how every function can be (ab)used.
Re:Size is the best predictor of code quality
by berntb on Monday September 26, 2011 @08:06AM
(#3038479)
If I wrote 2-20 line functions, then I wouldn't document/test every one, either.
Re:Size is the best predictor of code quality
by ZeroGravitas on Monday September 26, 2011 @08:53AM
(#3038607)
I think the idea is that the short functions call other (short) functions at a lower conceptual level to create a large amount of functionality. By testing that function, you're testing how they work together.
This is different from short functions being short because they don't do much.
The last time we debated this on HN, there was a disagreement about how much complexity the interactions between functions add to a program. To me, complex call graphs are even worse than complex code inside a function. I was surprised to learn that an opposing view even existed.