News for hackers. Stuff that matters.
Re:Looking at Our Nitpicks by withinboredom on Monday February 14, 2022 @09:47AM (#30332605)
I worked with a guy who would decline any PR that wasn’t written the way he would have written it (Voice of the Engineer). Any PR he reviewed nearly tripled the amount of time it would take to get for the reviewee to merge something (I researched this to give them feedback about nitpicking). The worst was they didn’t even realize they were nitpicking until literally the entire team was telling them to stop. They ended up leaving the company, thankfully.
Re:Looking at Our Nitpicks by sunny3 on Monday February 14, 2022 @01:26PM (#30335916)
I remember I read in HN somewhere that, people _want_ to feel useful in code reviews and one way is to leave comments. So one strategy is to send stuff out early with some small imperfections so that people who want to feel useful can pick on them. IMO, following this spirit, and in this case, an efficient but not necessarily personally beneficial strategy would be send out a PR early (so that you're not investing in too much time and not too emotionally invested in defending your solution later), then get them to suggest solutions, and implement in their way. This takes away pretty much all of the pleasure of creation in coding and deprives one of the sense of accomplishment, but it's far less frustrating and mentally straining than having to argue and defend which solution to adopt, to me, when working with that kind of people.
Re:Looking at Our Nitpicks by pc86 on Monday February 14, 2022 @10:40AM (#30333299)
Were they any better at finding edge cases or was their non-nitpicking feedback particularly insightful?