Re:A small guide for naming stuff in front-end code
by emptysea on Thursday January 13, 2022 @12:04AM
(#29917069)
TypeScript will produce an error when using a function inside and if stmt without calling it:
function f() {}
if (f) {}
This condition will always return true since this function is always defined. Did you mean to call it instead?(2774)
Re:A small guide for naming stuff in front-end code
by not2b on Thursday January 13, 2022 @05:00PM
(#29927507)
It seems that a linter tool would catch this even if TypeScript isn't used. In any case even if "get" is used, a coder might accidentally write
if (getBooleanProperty) { ... }
omitting the parens.
Re:A small guide for naming stuff in front-end code
by ravenstine on Thursday January 13, 2022 @12:00AM
(#29917052)
Except it's also likely, perhaps more so, that `this.finished` is `undefined`, which results in fundamentally the same problem but in the opposite direction of truthiness.
In which case I still see it as just a personal preference. The prefix of "is" becomes reassurance that something is intended to have a boolean value, which may be more important.
Of course it goes without saying that both of these things are (usually) addressed by a system like Typescript.
In our teams's js code we even include "get" for "is" properties (getIsEnabled() rather than isEnabled()) so that it's perfectly obvious if you're ever using a function without calling it.