News for hackers. Stuff that matters.

A comment on Ruby's Email Address Regexp. Parent comment

Re:Ruby's Email Address Regexp by gumby on Tuesday January 04, 2022 @10:46PM (#29804865)
Why 2? Greater than 0, sure.
[ Parent | on HN ]
Re:Ruby's Email Address Regexp by zamadatix on Tuesday January 04, 2022 @11:00PM (#29804964)
The index of the first character is 0 and an email must have a local part so that means the index of "@" has to be at least 1. My guess is OP also forgot the index of the first character is 0 instead of 1 resulting in 1+1=2 (that or they meant >=).

Off by one errors are about half of working with arrays.

[ Parent | on HN ]
Re:Ruby's Email Address Regexp by zarzavat on Wednesday January 05, 2022 @02:35AM (#29806209)
This is actually an uncommon example of an off-by-two error as they used strictly greater than 2.

  a@domain   fail
  ab@domain  fail
  abc@domain ok
[ Parent | on HN ]
Re:Ruby's Email Address Regexp by lostcolony on Tuesday January 04, 2022 @10:55PM (#29804932)
Yeah...I have an email address I use a lot, "me@(domain)". It's perfectly valid, despite indexOf("@") == 2.
[ Parent | on HN ]
Re:Ruby's Email Address Regexp by mkdirp on Wednesday January 05, 2022 @06:50AM (#29807878)
Heh, I actually meant `>=`. But as others have pointed out, that still excludes 2 letter users. Really it should be `>= 0`.
[ Parent | on HN ]
Re:Ruby's Email Address Regexp by lostcolony on Wednesday January 05, 2022 @11:42AM (#29811265)
> 0 I would think, no? Can an email address be '@domain', no preface?
[ Parent | on HN ]