News for hackers. Stuff that matters.

A comment on No code reviews by default. Parent comment

Re:No code reviews by default by Nursie on Tuesday January 04, 2022 @09:03PM (#29804013)
> Only for a drive-by take-down

Code reviews aren't a "take-down", they're a process of helping each other produce better solutions and better code.

> Even helpful review comments might only take a minute to write but a day to incorporate.

Then like all pieces of work, a decision must be taken whether that day is worth it, no?

[ Parent | on HN ]
Re:No code reviews by default by cfer43432t on Wednesday January 05, 2022 @09:35PM (#29818456)
That's what YOU think. But in practice they produce sub-par solutions and worse quality in my experience. Code reviews are basically a virtual piss-contest where people argue endlessly, everyone trying to show-off their intellectual superiority. And reviewers (not code authors) often can't handle rejection for some reason.
[ Parent | on HN ]
Re:No code reviews by default by Nursie on Thursday January 06, 2022 @01:55AM (#29820276)
It sounds like you've worked in some massively toxic teams. That's all I can say.
[ Parent | on HN ]