Re:Linus Torvalds Comments About Github
by bryanlarsen on Tuesday September 06, 2011 @09:07AM
(#2965418)
I'd be pretty leery of limiting who can send pull requests, but what Github needs to do is make it very clear that the big "merge pull request" button is usually a BAD idea unless it's a doc-only change. They should
- create a branch or tag containing the merge so that it's easy to pull the change without having to add additional remotes.
- provide instructions on how to pull, merge and push the request saying explicitly that the merge should be inspected and tested before doing the push.
- make the latter more obvious to click than "merge pull request" button
EDIT: I'm not saying that Linus needs this, but responding to Linus' comment about it being much too easy to do poor-quality commits.
Re:Linus Torvalds Comments About Github
by DasIch on Tuesday September 06, 2011 @02:18PM
(#2966568)
I think it would be nice if "pulling" would create a new branch (with a specifiable name) per default so that you can run tests and merge to master locally.
- create a branch or tag containing the merge so that it's easy to pull the change without having to add additional remotes.
- provide instructions on how to pull, merge and push the request saying explicitly that the merge should be inspected and tested before doing the push.
- make the latter more obvious to click than "merge pull request" button
EDIT: I'm not saying that Linus needs this, but responding to Linus' comment about it being much too easy to do poor-quality commits.