News for hackers. Stuff that matters.
Re:RCE in Visual Studio Code's Remote WSL for Fun and Negati... by SahAssar on Tuesday December 21, 2021 @05:24AM (#29635908)
Not making websockets follow the same-origin policy was a mistake.
Re:RCE in Visual Studio Code's Remote WSL for Fun and Negati... by willbudd on Tuesday December 21, 2021 @06:26AM (#29636312)
I suppose that case can be made, but in this case the direct cause of the vulnerability is the WebSocket server not checking the HTTP Origin header in direct violation of the standard (RFC6455), which is spells out at that doing so is a MUST. I could maybe understand whitelisting localhost and file URLs, but giving a carte blanche -on every single interface no less- is just absurdly negligent.
Re:RCE in Visual Studio Code's Remote WSL for Fun and Negati... by kevincox on Tuesday December 21, 2021 @06:44AM (#29636421)
This websocket was also listening on external interfaces so a non-browser client could have sent whatever headers it wanted.
Re:RCE in Visual Studio Code's Remote WSL for Fun and Negati... by ravenstine on Tuesday December 21, 2021 @09:44AM (#29637803)
In fairness, couldn't the same things still be accomplished with cross-origin POST/GET requests? Not that there isn't some regretability to not making those strictly same-origin as well.