News for hackers. Stuff that matters.
Re:Ask HN: I'm tired of intense code review cycles by Osiris on Friday December 17, 2021 @11:23PM (#29601622)
I often approve a PR with the comment "Approved with comments".

In other words, I didn't notice any bugs but I have some suggestions. I'll let you decide if you want to make the changes or not.

Re:Ask HN: I'm tired of intense code review cycles by aredplug on Friday December 17, 2021 @11:47PM (#29601743)
+1. The job of reviewer on shared codebases is advisory, not as a gatekeeper.

If people choose to ignore comments, then that's a behavioral issue worth escalating.

Re:Ask HN: I'm tired of intense code review cycles by un_montagnard on Saturday December 18, 2021 @01:04AM (#29602133)
I've been in teams where those comments are never addressed because the pressure is on "push something that roughly solves the task so you can show something during demo".