News for hackers. Stuff that matters.

A comment on A bot fixes spelling mistakes in github readme files.

Re:A bot fixes spelling mistakes in github readme files by jrockway on Sunday August 28, 2011 @08:22PM (#2935385)
Interesting idea, although it would be nice if Github optionally fixed spelling mistakes for you. Pull requests just for spelling errors have got to be annoying. (I just run flyspell in Emacs, so I never make spelling mistakes. Accept when I use the wrong word.)

The code is also pretty interesting. It's old-style Perl with indirect method calls, bareword filehandles, no "use strict", and so on... but then it uses modules that use Moose and MooseX::Traits. So we have a collection of scripts that look like they are from 1987, but that depend on Moose. Excellent!

(Actually, this inspired me to read the source code for Net::Twitter to see if it was using MooseX::Traits. Turns out they just copy-pasted from an older version of MX::Traits to get their traits functionality. Weird!)

[ Parent | on HN ]
Re:A bot fixes spelling mistakes in github readme files by holdenk on Sunday August 28, 2011 @10:27PM (#2935630)
Sorry the perl code is so poor, it was a post-clubbing quick-hack type project. I'll clean it up when I have some free time again :)
[ Parent | on HN ]
Re:A bot fixes spelling mistakes in github readme files by draegtun on Monday August 29, 2011 @08:45AM (#2936936)
You may find the following CPAN modules helpful when you do your refactoring:

* Net::GitHub - http://p3rl.org/Net::GitHub

* Pithub - http://p3rl.org/Pithub

[ Parent | on HN ]
Re:A bot fixes spelling mistakes in github readme files by holdenk on Thursday September 08, 2011 @02:58AM (#2972918)
Oh excellent. I only looked at Net::GitHub initially, but Pithub looks more interesting.
[ Parent | on HN ]
Re:A bot fixes spelling mistakes in github readme files by rat on Monday August 29, 2011 @03:20AM (#2936300)
I thought using moose turned on warnings+strict(at least its claimed here http://stackoverflow.com/questions/6050031/why-are-use-warni...)
[ Parent | on HN ]
Re:A bot fixes spelling mistakes in github readme files by draegtun on Monday August 29, 2011 @08:35AM (#2936915)
It does. However warnings+strict are lexical so it will only apply to the module or scope where use Moose is put.
[ Parent | on HN ]
Re:A bot fixes spelling mistakes in github readme files by glenjamin on Monday August 29, 2011 @05:24AM (#2936538)
> Accept when I use the wrong word.

I can't tell... was that intentional?

[ Parent | on HN ]