If we’re stuck with rockets that either lift tiny payloads or are ludicrously expensive to launch (see SLS’ $2B-$4B estimated cost per launch), I think your predictions are right on the mark. In that situation building anything even remotely luxurious is not practical.
If we assume the existence of something like Starship+Superheavy as it’s currently planned, that starts to change. You’re still not going to see O’Neill cylinders, but simple ring stations with interiors nice enough to be resorts are within grasp.
To achieve things as fully as depicted in these images, extraction of resources and manufacturing in space will be necessary. Even with cheap superheavy launch, lifting all the required material to orbit isn’t a practical consideration. Achieving those prerequisites is helped quite a lot by Starship though, because it’s more than enough to bootstrap asteroid mining operations and the like.
Given the risk of random super high speed/energy collisions with space objects, I would wonder if a more resilliant craft shape might be based on something nested and self-simlar, literally, "bigger on the inside," or like a disconnected formation that isn't physically connected. An orbital craft in a relatively stable solar system that used a planet as a lower energy "mooring ball" might allow for simpler geometric craft forms, but there's probably a maximally optimal shape for deep space starfaring vehicles. (oumuamua was very oblong and cylindrical, which might be a hint).
I think we'll actually see more of similar designs, even if much smaller, e.g. in spacecrafts for human journeys beyond the Moon and, indeed, space stations.
Interestingly, many very recent Sci-Fi movies involving realistic-ish human space travel feature spacecrafts with spinning toroidal living quarters.
Some less recent ones too [1]. It never ceases to impress me that this was filmed before the moon landings.
Don't forget Gene Wolfe's marvelous The Book of the Long Sun!
One, they had a significant impact on the science fiction that came after them. We see recapitulation of this imagery in a lot of '70s-'90s anime (less often in live action, which I attribute to cost to film it).
Two, I believe when we get anywhere near a technology level to try something like this, the result will look radically different. I'm reminded of the way that old depictions of the Earth from space rarely included the clouds, which are omnipresent and unavoidable when actually looking at the planet. Some things, a person just can't imagine until they're there.