News for hackers. Stuff that matters.

A comment on Git techniques. Parent comment

Re:Git techniques by omegalulw on Thursday November 11, 2021 @10:37AM (#29189043)
> I have to disagree with this as it relies on the assumption that every commit on a branch is logical and descriptive. In my experience a lot of PRs will have small commits that have poor names as they go through a review process.

There's your problem. Code reviews should not allow such commits to pass through.

[ Parent | on HN ]
Re:Git techniques by t3h2mas on Friday November 12, 2021 @11:04AM (#29200689)
> Code reviews should not allow such commits to pass through.

Are you suggesting that your code review process has a stage for combing through commit messages? What does this look like? If the third commit message of 15 isn't up to par what happens?

[ Parent | on HN ]
Re:Git techniques by derekperkins on Saturday November 13, 2021 @11:14AM (#29210792)
You ask them to fix the commit message. Every git GUI should support that by now, so it should be a 1 minute fix, even for junior devs.
[ Parent | on HN ]