News for hackers. Stuff that matters.

A comment on Error handling with errgroups. Parent comment

Re:Error handling with errgroups by reltuk on Friday October 29, 2021 @06:08PM (#29044072)
I think the contract in the context package is that WithCancel may leak resources if cancel is not called and the parent context is cancelable but never canceled. At least, that seems to be the behavior I see in the implementation here:

https://github.com/golang/go/blob/master/src/context/context...

So in this case, errgroup probably doesn't have a choice and needs to call cancel() at some point.

[ Parent | on HN ]
Re:Error handling with errgroups by scottlamb on Friday October 29, 2021 @08:59PM (#29045112)
Ahh. Yeah, that's unfortunate but explains this choice.

btw, I realized I'm not being entirely fair in saying it caused a bug. There would have been one anyway. If conflictsBuilder.Wait() failed, it wouldn't cancel the other two operations. It'd wait them out even though the overall operation was doomed. Maybe not a very noticeable bug under normal conditions but still not right.

[ Parent | on HN ]