News for hackers. Stuff that matters.

A comment on Cross-Site Scripting? In PHP Notices? It's more likely than you think. Parent comment

Re:Cross-Site Scripting? In PHP Notices? It's more likely th... by nbpoole on Thursday August 18, 2011 @02:18AM (#2898201)
> So could PHP perhaps HTML encode error messages? Would this break any error message use cases? For example are there times when error messages appear when they wouldn't be interpreted as HTML encoded? CLI? Browsers loading different text mime types?

This is something PHP already gets right with warnings, fatal errors, etc. The issue is only with notices as far as I've seen (I haven't delved into the PHP source to see what the difference is).

A demonstration file:

    [cmd]$ cat 147b9119e818c92f7f74bad71cc12255.php
    <?php
    echo file_get_contents('<s>test</s>');
Compare:

    [cmd]$ php -f 147b9119e818c92f7f74bad71cc12255.php

    Warning: file_get_contents(<s>test</s>): failed to open stream: No such file or directory in /home/nbsandbox/sandboxing.me/poc/147b9119e818c92f7f74bad71cc12255.php on line 2
to

http://sandboxing.me/poc/147b9119e818c92f7f74bad71cc12255.ph...

    <br />
    <b>Warning</b>:  file_get_contents(&lt;s&gt;test&lt;/s&gt;) [<a href='function.file-get-contents'>function.file-get-contents</a>]: failed to open stream: No such file or directory in <b>/home/nbsandbox/sandboxing.me/poc/147b9119e818c92f7f74bad71cc12255.php</b> on line <b>2</b><br />
[ Parent | on HN ]
Re:Cross-Site Scripting? In PHP Notices? It's more likely th... by georgefox on Thursday August 18, 2011 @09:06AM (#2899020)
I know what you mean, but the link you provided doesn't actually seem to be doing any HTML encoding.
[ Parent | on HN ]
Re:Cross-Site Scripting? In PHP Notices? It's more likely th... by nbpoole on Thursday August 18, 2011 @09:15AM (#2899051)
Haha, whoops! Sorry about that, back to normal. Anyone who hit that URL in the past 10 minutes would have seen unsanitized HTML, because I was testing the impact of disabling the html_errors INI option (something one of my blog's comments asked about). I've updated the blog post to discuss html_errors as well. ;-)
[ Parent | on HN ]