There's a substantial net benefit in doing this. There are other cloud providers focused on the government market today (Terremark, EDS, Savvis), all using mainly VMware or in some cases Hyper-V; the benefits of being able to use EC2 are that EC2 is in a lot of ways more innovative itself, and that a lot of companies using EC2 can now build a Federal version by just running an instance in a new zone, rather than negotiating for a new hosting provider and porting all their provisioning infrastructure to a new system.
The stuff that will be put on here will mostly be stuff that's a little confidential, but not particularly threatening.
Obviously, it's still a threat if somebody got it all in one hit. But Gmail and Facebook would hold much more useful data.
I don't think any of the Amazon GovCloud stuff will be used for anything classified, at least for the next few years. It will mainly be used for Sensitive but Unclassified or For Official Use Only type data, which is the vast majority of day to day data processed.
What probably will happen is FOUO/Unclass apps will be developed for GovCloud about 80% as well as on the public internet (which is a huge improvement over things now), and then the users who also have classified needs will complain about how crappy their classified apps are by comparison, then ask for a solution -- which probably will be an EC2-compatible classified cloud owned by the government and operated by a contractor (such as "Amazon Federal Systems" or an Amazon, Inc. partner). It might be dedicated per agency or command. It might just be an EC2 rack appliance in existing DoD datacenters.
This is a great first step toward that.