How suitable is it for reading PDFs with code/diagrams?
Basically the best thing I have ever used for PDF's with graphics/formulas/code. I am a very happy user.
It's excellent, with one important caveat: provided the text size is not too small. The way small font sizes (<=8pt on an 8.5x11 PDF page) get rendered/antialiased on the device reduces their contrast a little -- they end up a little more grey than pure black, which isn't ideal.
I convert everything to PDF before moving it to the device though, for a lot of reasons, some aesthetic and some related to lack of functionality in the built-in epub converter. It's a shame there is no software that does a perfect job at converting epub to PDF though. I use one of three different workflows depending on the source material.
One tip for those using the device: the built-in margin trimming feature for PDFs also lets you add margins on whatever side of the document you want, which is a bit counterintuitive but really useful if you like scribbling in the margins.