Re:I ruin developers’ lives with my code reviews and I'm sorry
by phendrenad2 on Wednesday September 15, 2021 @04:37PM
(#28544057)
That is exactly why many harshly critique code. But I've never found their versions to be any less full of tech-debt. Usually it comes down to personal style. "Oh Brenda hates if/else, better convert it to ternary before I submit it. But Oh No! Bob is reviewing it instead! He hates ternary and always wants if/else! I'm doomed..."
Re:I ruin developers’ lives with my code reviews and I'm sorry
by Thiez on Wednesday September 15, 2021 @05:28PM
(#28544605)
Sounds like that team should define a style guide and stick to it. Either Brenda or Bob is going to be disappointed for a bit, but the code will be more consistent in the end.
Re:I ruin developers’ lives with my code reviews and I'm sorry
by dwaltrip on Wednesday September 15, 2021 @06:09PM
(#28545032)
This is why automatic code formatters such as Prettier -- are absolutely genius for teams. (It doesn't work for your particular example of ternary vs. if/else but the point still holds.)
Re:I ruin developers’ lives with my code reviews and I'm sorry
by dreyfan on Wednesday September 15, 2021 @05:40PM
(#28544727)
If code reviews are centered around style the entire org is fucked.
Re:I ruin developers’ lives with my code reviews and I'm sorry
by Rexxar on Wednesday September 15, 2021 @04:38PM
(#28544071)
> Because it creates technical debt
Does it ? Sometimes, the code reviewer has taken less time to analyze the problem and has not seen all problems a simpler solutions would bring.
Because it creates technical debt, that's why people get frustrated with shit code. They just aren't properly equipped how to convey/teach/train/fix it without coming across like an asshole.