Re:I ruin developers’ lives with my code reviews and I'm sorry
by backoncemore on Wednesday September 15, 2021 @04:10PM
(#28543751)
The sweet spot is somewhere in the middle. Too laissez-faire and you end up with a ball of mud.
[ Parent
| on HN ]
Re:I ruin developers’ lives with my code reviews and I'm sorry
by marktangotango on Wednesday September 15, 2021 @04:17PM
(#28543839)
Super critical code review culture can also end up with balls of mud. The two are not exclusive. Example is a team I was on that would critique the hell out of syntax and grammar in javadocs, formatting of annotations arguments, stuff like that, fine. But never look outside the source file for how any of it fit together. No design planning cause "code reviews". End result was tons of duplicated code everywhere.
Re:I ruin developers’ lives with my code reviews and I'm sorry
by jsight on Wednesday September 15, 2021 @04:52PM
(#28544208)
I've submitted code that was reviewed like that, and it was super frustrating. Stuff like, "your javadoc uses invalid markup", when submitting code to a project that has almost zero javadoc to begin with.
I mean, sure it doesn't render well as HTML, but its readable with the code and the rest of the project has none so...