Re:I ruin developers’ lives with my code reviews and I'm sorry
by mmmpop on Wednesday September 15, 2021 @04:09PM
(#28543743)
Maybe you just write incredible code the first time, every time? Can't discount the possibility!
[ Parent
| on HN ]
Re:I ruin developers’ lives with my code reviews and I'm sorry
by sdenton4 on Wednesday September 15, 2021 @04:12PM
(#28543778)
IME, if the tests don't fail the first time you run the code, it says that the tests aren't actually hitting the new behavior. (Maaaaybe 1 in 100 times the code is actually right the first time.)
Likewise, if there's no comments on a pull request, it hasn't been read...
Re:I ruin developers’ lives with my code reviews and I'm sorry
by jimmaswell on Wednesday September 15, 2021 @04:42PM
(#28544107)
I'd have agreed once, but at some point in my life I realized most of my code really was working right the first time, even messy javascript. Anyone else have this experience?
Re:I ruin developers’ lives with my code reviews and I'm sorry
by carlmr on Wednesday September 15, 2021 @05:50PM
(#28544810)
Depends on the language. Strongly typed languages like Rust and F#, even Typescript to some degree, yes. Most of the time if it compiles it works.
Re:I ruin developers’ lives with my code reviews and I'm sorry
by billycorben2 on Wednesday September 15, 2021 @04:16PM
(#28543823)
I don’t think this is me, haha