Re:Python Anti-Pattern
by dragonwriter on Wednesday September 15, 2021 @05:27PM
(#28544602)
Both mypy and pyright/pylance do the right thing when things are guarded with explicit None checks and the wrong thing with “or”, so even though I prefer “or” otherwise when its gated upstrean so that None is the only falsey value it should get, I’ve taken recently to using explicit checks to make typecheckers happy.
That's not been my experience. I frequently use or way and have both mypy/pyright enabled. Testing this toy function,
from typing import List, Optional
def f(x: Optional[List[int]]): x = x or [] reveal_type(x)
mypy and pyright both show List[int] as type of x at the end and correctly drop None.
I think using `or` for default fallbacks is generally considered bad practice because it disallows all falsey values, like `0` and `{}`.
It doesn't matter in this particular case because the only falsey List is `[]` anyway, but it's a bad habit.
JavaScript added the `??` operator for this specific problem.
Re:Python Anti-Pattern
by patrick451 on Wednesday September 15, 2021 @09:36PM
(#28546892)
I've never thought of this as a footgun. It's useful to accumulate state in a function, sort of like a static variable in c. E.g.,
def func(x=[]):
x.append(5)
return x
I've always been annoyed that pylint yells at you for this.
Re:Python Anti-Pattern
by ViViDboarder on Thursday September 16, 2021 @12:22AM
(#28547984)
The issue is that it’s a non-apparent side effect to an outside caller.
Also is there a reason for not using the shorter:
var = var or []
Instead of:
var = [] if var is None else var