News for hackers. Stuff that matters.

A comment on Ship / Show / Ask: A modern branching strategy. Parent comment

Re:Ship / Show / Ask: A modern branching strategy by refenestrator on Monday September 13, 2021 @10:50AM (#28512212)
90% of people are fine and code review has tons of benefits.. but the format is an enabler for 'that guy', as you're asking them for approval rather than running it by them as an FYI.

I've seen a few different motivated hard workers get to hard work on demanding as many changes as possible whenever they are on a CR.

[ Parent | on HN ]
Re:Ship / Show / Ask: A modern branching strategy by dv_dt on Monday September 13, 2021 @11:57AM (#28513102)
There is also the flip side too where a block of code might just have a lot of problems and I’m trying to evaluate if it’s too hard in a public forum to flag all of them at once. If possible I try to flag a couple and to sit down and offer to do a one on one for more.
[ Parent | on HN ]
Re:Ship / Show / Ask: A modern branching strategy by refenestrator on Monday September 13, 2021 @12:29PM (#28513466)
+1 to taking it offline when it's more than a couple minor style fixes.
[ Parent | on HN ]