Ship / Show / Ask: A modern branching strategy

Re:Ship / Show / Ask: A modern branching strategy by city41 on Monday September 13, 2021 @08:47AM (#28510817)

Although I do agree with all of this. I sometimes feel like "distributes the responsibility" can actually cause things to slip through the cracks. The reviewer thinks "eh, I didn't write this, what I saw looked fine" and the author thinks "hey they approved it, so I'm not out on a limb here", causing both sides to look at the code less closely.

I'm not saying that always happens, but it does sometimes in my experience.

[ Parent | on HN ]

Re:Ship / Show / Ask: A modern branching strategy by mumblemumble on Monday September 13, 2021 @09:32AM (#28511245)

One team I used to work on had a really healthy way of dealing with this. Whenever a bug made it through to production, the team would have an informal post-mortem meeting where everyone who worked on the change in question would talk about the cause of the bug, and perhaps try to identify ways something like that could have been avoided.

There was no real interest in assigning blame to individuals. I think that was largely because we required two reviewers to approve every code review. So, when something did happen, it had to make it past at least three people. That automatically makes the mistake a team responsibility and not an individual one.

[ Parent | on HN ]