Re:Postgres: Boundless `Text` and Back Again
by brandur on Friday September 10, 2021 @02:46PM
(#28485582)
I used to recommend `CHECK` constraints as well, but was directed towards Postgres' very good intelligence around being able to relax a `VARCHAR(n)` -> `VARCHAR(>n)` as basically a no-op, so I simplified here somewhat just because VARCHARs are easier to use, and make much more succinct examples in write ups like this one.
The index rebuild is still a bit of an open question — I wouldn't be surprised if Postgres had some optimizations there as well to not need it in instances where it's not necessary, but I might be wrong on that one.
Re:Postgres: Boundless `Text` and Back Again
by masklinn on Friday September 10, 2021 @03:56PM
(#28486230)
> I used to recommend `CHECK` constraints as well, but was directed towards Postgres' very good intelligence around being able to relax a `VARCHAR(n)` -> `VARCHAR(>n)` as basically a no-op
I don’t think that’s the case when you have views on the table though.
The locking could also be a concern, altering the table will almost certainly need an exclusive write lock, altering a contraint may not (to check). Even if the operation is very short, the need to block every read coming after the DDL can be quite impactful to service.
Re:Postgres: Boundless `Text` and Back Again
by masklinn on Saturday September 11, 2021 @05:53AM
(#28490691)
Can't edit anymore but after checking up on https://www.postgresql.org/docs/current/sql-altertable.html only `FOREIGN KEY` constraints can get by with a lock below ACCESS EXCLUSIVE. So constraint or column makes no difference to the locking, sadly.
Eg: `ALTER TABLE users ADD CONSTRAINT username_max_len CHECK LENGTH(username) <= 100 NOT VALID;`
The NOT_VALID option skips checking the existing data, so the migration is quasi-instant.
That way the constraint can easily be swapped out by removing the old one and adding a new one, and you have maximum flexibility going forward.
This also doesn't require an index rebuild, and better models what's actually happening internally.