Re:Everybody makes mistakes when writing comparison functions
by coldpie on Thursday September 09, 2021 @10:24AM
(#28470009)
Having unused parameters is super common, especially when using function-pointer-based APIs like qsort. Arguably they should have annotated the arguments to suppress the warnings, but that starts to get into compiler compatibility (OpenSSL is used on a _lot_ of systems with a _lot_ of compilers) and becomes a much larger question than just setting -Wno-unused-parameter.
[ Parent
| on HN ]
Re:Everybody makes mistakes when writing comparison functions
by commandlinefan on Thursday September 09, 2021 @12:22PM
(#28471412)
> especially when using function-pointer-based APIs like qsort
Well, the function should be called somewhere, even if it's ignored when null. I can't think of a legitimate case for an unused parameter - it might be #ifdef-ed out in some cases, but it should still be referenced somewhere.