Re:Linus Torvalds: “GitHub creates useless garbage merges”
by anonymoushn on Monday September 06, 2021 @04:56PM
(#28438026)
These issue numbers are non-portable even within github! Two repositories may have the same commits in them but different sets of issues.
[ Parent
| on HN ]
Re:Linus Torvalds: “GitHub creates useless garbage merges”
by est31 on Monday September 06, 2021 @05:03PM
(#28438090)
My favourite is when someone collaborates on a PR and they create PRs for the PR's branch in the forked repo. That repo has its own numbers so you'll end up with merge commits referencing PR #4 in the main repo.
Re:Linus Torvalds: “GitHub creates useless garbage merges”
by jareklupinski on Monday September 06, 2021 @11:11PM
(#28440515)
this came very close to exposing private repo details to the wrong users for me recently
currently trying to find an exploit using this 'feature'
Re:Linus Torvalds: “GitHub creates useless garbage merges”
by tadfisher on Monday September 06, 2021 @06:22PM
(#28438775)
Because forks are GUI sugar for refs in the main repo.
This is also why Actions have convoluted security implications.
Re:Linus Torvalds: “GitHub creates useless garbage merges”
by est31 on Monday September 06, 2021 @09:33PM
(#28439897)
No I didn't mean the "you can replace the fork's URL with the main repo one and make the commit seem part of the repo". That's a weird github oddity to keep in mind, but not the issue I meant. I meant when that PR including its merge commits gets merged. Then those commmits become proper members of the main repo.