On chrome(os) at least if you move the editor to it's own fullscreen window all keys are passed to the editor.
There's probably a way to make this work without requiring the window to be fullscreen.
https://www.cnet.com/how-to/this-setting-makes-chrome-os-fee...
You can also use "chromium --app $url" and you'll have these key bindings available. If you want to use github isolated from your browser history, you can use it like so:
[$] chromium --user-data-dir=$HOME/github_or_whatever --app="https://github.com/orga/repo" --new-window;
edit: If you use MacOS or Windows, my browser wrapper script from another project might give you some hints on how to use Safari or Edge this way [1].
[1] https://github.com/tholian-network/stealth/blob/X0/browser/b...
It's interesting to see how suitable is the IDE for code review for different people. For me, it's usually pretty much overload, since it's focused on writing, not reading. But GitHub is really doing a great job of eliminating the necessity of cloning the branch for the review.
I'm doing a few experiments in this area on a tool called Viezly (example: https://viezly.com/change_requests/3986). Its focus is on dependency and navigation. So it's a light version of IDE-in-the-cloud for these cases of code review.
This kills me with Jupyter. Open bash kernel, make typo, Ctrl+w, sigh as tab disappears. I often open and pin several empty tabs so it only kills the tab, not the whole window.
Agree, except code formatting (e.g. w/ Prettier) is missing - which would make it extremely helpful to do small PRs.
Now I just have to change the other bindings (and relearn).
1. Go to any Github repo 2. Press . 3. Wait for the editor to load... 4. Press Ctrl/Command + P 5. It opens VSCode's "Go to File" prompt
Too bad cmd+w, ctrl+tab, and ctrl+shift-tab doesn't close an editor tab / switch editor tabs… and if you hover on the close icon, it just tells you to use cmd+w instead of something else.
Considering that there was obviously going to be a keyboard-clash, their approach seems to be very pragmatic.
All of this works for me when I am in full-screen mode.
- Just exploring some code.
- Quickly pull up as reference code w/ decent navigation without having to checkout locally or navigate forward/back in the source tree in GitHub.
- When reviewing PRs and wanting to check out some surrounding code that is not part of the actual PR.
- If you want to quickly commit something really small and trivial in master/a branch/a PR without having to do the whole stash/checkout/pull/change/commit/push rigmarole (like if you're in the middle of doing something else).
Things that are very annoying:
- Some of the most used VSCode hotkeys are browser hotkeys, like Ctrl+T, Ctrl+P, Ctrl+Shift+P etc. The functions aren't even rebound to anything else, they're just not available via hotkeys.
- Some extensions are not available, especially ones that (partially) may rely on some kind of local binary. I understand that, but that also sometimes rules out extensions that could partially work. Example: none of the Zig extensions work because they reference tooling binaries, so I can't even get syntax highlighting of Zig code. You could argue that's an extension packaging issue, however. That's fair.
- The PR reviewing UI needs a lot of work, because right now it's not as good as the normal GitHub UI, so currently, for larger PRs, I need to have both UIs open.
I hope in the future you can save a gist or something with custom settings/hotkeys/extensions to load. I'm sure they're working on something like that.
Update: Oh, there actually is some form of settings sync. Have to check that out.