Nothing wrong with it, and it absolutely will stop any kind of casual or software recovery.

However, physically destroying the disk is the only way to be sure. And amusingly, it's often faster to physically destroy the disk than it is to run shred on it at today's capacity to write speed ratios.

Bonus, not only does physical destruction cover non-working sectors it works on entirely non-functioning disks.

In short, no. Often a plain old zero pass is good enough, but shred defaults to doing three random passes and that'll be sure to destroy any hopes of recovery.