Ideally they wouldn’t be able to scan my iCloud photos at all. There’s real value in being able to maintain privacy while also gaining the benefits of live, remote storage and backup.

The generous interpretation is that Apple moved this on-device to preserve user privacy. They just miscalculated the response to an admitted backdoor.