News for hackers. Stuff that matters.
Re:Get your GitHub badge now by johns on Saturday July 30, 2011 @08:47PM (#2827238)
Total project followers is more interesting to me than how many follow me directly.
Re:Get your GitHub badge now by BYK on Sunday July 31, 2011 @04:09PM (#2829402)
Added, thanks for the suggestion! =)
Re:Get your GitHub badge now by javery on Saturday July 30, 2011 @08:08PM (#2827164)
Why use an iframe? Async javascript would be better all around. Also - when you click you name in the badge it opens the link inside the small iframe.
Re:Get your GitHub badge now by ryanpetrich on Saturday July 30, 2011 @08:23PM (#2827194)
iframes don't block the outer page from loading or expose the page's security context (cookies, etc) to the external domain.
Re:Get your GitHub badge now by javery on Saturday July 30, 2011 @08:40PM (#2827223)
Async JS doesn't block either - and cross-domain scripting rules are strict enough that it is pretty safe. The iframe code has an async Google Analytics script in it - perhaps that is the reason for the iframe (to use google analytics for tracking usage).
Re:Get your GitHub badge now by JoshTriplett on Saturday July 30, 2011 @09:20PM (#2827306)
Curious what you mean about cross-domain scripting rules and safety. Normally, loading a third-party script via a script tag lets that script do anything the page can do, which makes it decidedly unsafe.

Personally, I greatly prefer the iframe.

Re:Get your GitHub badge now by javery on Saturday July 30, 2011 @10:13PM (#2827409)
You're correct - it can do just about anything. Technically it can't make ajax calls back to a domain other than where the page was served from - but you could get around that by just inserting more javascript tags.

iFrames do offer a little more security here - but in this case I would still go for just script since I don't see that the downsides outweigh the added security. (you can still do a whole ton of damage from an iframe)

Re:Get your GitHub badge now by JoshTriplett on Saturday July 30, 2011 @10:17PM (#2827419)
What damage can you do from an iframe? You don't have any of the permissions of the site containing the frame.
Re:Get your GitHub badge now by javery on Sunday July 31, 2011 @11:46AM (#2828575)
You can deceive the user pretty easily with content that looks like the main page and prompts them to do something you want them to do. (like login to the parent app even though they are logging into your app, anti-phishing stuff won't take effect if you keep it all in the iframe)

You could also just execute whatever JS you want if there is a browser vulnerability you want to take advantage of.

Re:Get your GitHub badge now by BYK on Saturday July 30, 2011 @08:48PM (#2827244)
Javascript version is on the horizon. We used iframe because it was quick&dirty and "good enough" to start with =)
Re:Get your GitHub badge now by berkerpeksag on Saturday July 30, 2011 @08:39PM (#2827221)
Fixed. Thanks.
Re:Get your GitHub badge now by t4nkd on Saturday July 30, 2011 @10:15PM (#2827416)
Number of times I've commented on an HN story: 0

Number of times I've followed up on GitHub related news, anywhere: n + rand(50..100) # => always

Times I've thought that Github is growing sickeningly commercial, that my attempt at best practice and code sharing is equating to (millions of) dollars in their pocket, and that other seemingly like-minded individuals want to capitalize on their successes to achieve notice: At least twice.

At least when Dr. Nic made this widget, it seemed original.

Re:Get your GitHub badge now by BYK on Sunday July 31, 2011 @04:09PM (#2829399)
This is a pet project and we gain nothing but experience. We were not aware of any similar projects when starting. In terms of capitalizing, please keep in mind that there are no ads and we do not intend to add any so it will cost us in the contrary when more people start to use this.
Re:Get your GitHub badge now by Mathnerd314 on Sunday July 31, 2011 @04:43PM (#2829520)
You could add a (small) donation link
Re:Get your GitHub badge now by BYK on Sunday July 31, 2011 @04:54PM (#2829552)
We may when the service actually starts to cost us =) Thanks ;)
Re:Get your GitHub badge now by lee337 on Saturday July 30, 2011 @11:52PM (#2827567)
Nice work! With this, coderwall and all my soccer trophies/medals... my parents' fireplace will never be the same again :-)
Re:Get your GitHub badge now by gus_massa on Sunday July 31, 2011 @09:04AM (#2828243)
In IE8 the badge is a few pixels too wide and an horizontal scroll bar appears.
Re:Get your GitHub badge now by jamesbritt on Sunday July 31, 2011 @12:42AM (#2827644)
Will this help me write more or better code, or release more often?
Re:Get your GitHub badge now by mtogo on Sunday July 31, 2011 @01:16AM (#2827680)
Not everything is about releasing more often.
Re:Get your GitHub badge now by DrJ on Sunday July 31, 2011 @02:49AM (#2827808)
firefox/mozilla's product managers disagrees :(
Re:Get your GitHub badge now by vmind on Sunday July 31, 2011 @05:17AM (#2827966)
It seems to choke if you have a hyphen in your username.
Re:Get your GitHub badge now by BYK on Sunday July 31, 2011 @04:05PM (#2829392)
It's already fixed. Thanks for reporting! =)
Re:Get your GitHub badge now by bltavares on Saturday July 30, 2011 @09:35PM (#2827331)
Really awesome. It's on my page already
Re:Get your GitHub badge now by ahmetalpbalkan on Monday August 01, 2011 @01:44PM (#2833438)
awesome project