The ADHD subreddit actually banned all use of the words "neurodivergent", "neurotypical", etc. awhile back, which I think was an overaction, but they were trying to get the sub back to a place where it could be used for advice to manage ADHD, not a place to play identity politics and tell people they should actually be thankful for their disorder.
You have a good point that high achieving individuals are less likely to be diagnosed, and high intelligence does seem to lead to some of these issues more often than they are seen in an average individual. However, the vast majority of people with these conditions are not part of that very small "gifted" category, and I think you'll be hard pressed to find "gifted" people in the neurodiversity movement. Historically these individuals have been left out of accomodations and wish they had received appropriate help for their impairments.
Might that be because many people who like their traits don't consider themselves neurodivergent, and don't get called that by others?