News for hackers. Stuff that matters.
Re:Google broke a conditional statement that verifies passwo... by vlovich123 on Thursday July 22, 2021 @05:05PM (#27924333)
This isn’t extreme negligence of any single individual. If there are linters/compiler warnings that should have caught this, this is an organizational failure that can be remedied and the manager/TL should be taking a bit of a hit here as having those enabled is best practices. Since it’s ChromeOS I imagine there’s a dedicated team managing the build infra and it’s not using the base set of things that Google3 protects you with, so the fault may lie in that organization a bit as an oversight.

Then there’s obviously the automated testing strategy, manual testing strategy and sanitizer strategy that missed this.

The net result is extreme negligence but to me this kind of failure speaks to several layers going wrong at once rather than one person fucking up badly. Organizationally you try to defend against these kinds of failures with multiple layers of defenses.

Now if this was a malicious internal attack that should be investigated but I’d hate to have to seriously reprimand anyone who typo’ed & instead of &&.

Re:Google broke a conditional statement that verifies passwo... by ectopod on Thursday July 22, 2021 @05:58PM (#27924873)
The GGGP is talking about failures at a higher level. Not reprimanding the coder who missed an ampersand, but the manager who was ultimately responsibly for ensuring there was a functioning process for catching this sort of nonsense.
Re:Google broke a conditional statement that verifies passwo... by vlovich123 on Thursday July 22, 2021 @10:32PM (#27926575)
In situations like these there's not really one manager, so who are you reprimanding? I'm sure there's failures all around. Seriously, blameless post mortems are a cultural thing you need to adopt. Reprimanding just instills fear which causes people to take actions that you don't want organizationally (shifting blame/responsibility, hiding issues, politicking etc). Better for people to just be proactive about when a problem exists & marshal your org to prevent such issues in the future. It's unlikely to be the cause of 1 individuals incompetence so any individual(s) you find to blame are just victims of circumstance.

Where you do want to reprimand is if the technical team was repeatedly raising concerns related to failures like this & their concerns weren't being addressed OR someone was being deceitful & hiding issues. That's about the only cases where you want to fire/replace anyone in my book.

Re:Google broke a conditional statement that verifies passwo... by nicoburns on Thursday July 22, 2021 @07:16PM (#27925479)
Reprimanding is one thing and firing another though. I certainly think the manager in charge deserves a reprimand.
Re:Google broke a conditional statement that verifies passwo... by ascagnel_ on Friday July 23, 2021 @10:22AM (#27930969)
I wouldn't even say a reprimand is necessary here.

Programming safety is like safety in auto racing or rock climbing: you build the safest thing you can, but the activity you're doing is inherently unsafe, and it will generate failures despite the presence safety measures, so you do your best to study those failures to mitigate them the best you can.

The only time adverse action like a reprimand is necessary is if the manager or tech lead don't take any action to prevent future issues. The only time a firing is necessary is if the security issue was created with intent, rather than accidentally.

Re:Google broke a conditional statement that verifies passwo... by sneak on Sunday July 25, 2021 @05:49PM (#27953242)
This specific type of failure is evidence that they didn't build the safest thing they can.

Linting catches this.