Commit often, perfect later, publish once: Git best practices (2013)

Re:Commit often, perfect later, publish once: Git best pract... by vlovich123 on Sunday July 04, 2021 @10:17AM (#27729783)

When I was at FB, there’s no PR as defined at GitHub. Each independent commit was a separate review. So in that sense, all of the 10s of thousands of engineers at Facebook daily review “PRs” at the commit level.

[ Parent | on HN ]

Re:Commit often, perfect later, publish once: Git best pract... by angrais on Sunday July 04, 2021 @01:56PM (#27731421)

In that case, where you then recommended to only make one commit? Are there guidelines for the average/ideal commit length? Did this add to extra workload in creating "perfect" commits? Likewise, did this mean that pushing "WIP" commits to remote was rare?

[ Parent | on HN ]

Re:Commit often, perfect later, publish once: Git best pract... by vlovich123 on Monday July 05, 2021 @02:26AM (#27735154)

Felt like less workload because each commit had independent feedback that you could address resolve. Then you could push each commit as it was ready (or whichever part of the stack was).

Wip commits we’re often and frequent for CI purposes but as with PRs you don’t want to waste too much review time on WIP unless your asking for some preliminary feedback on a complex change.

Ideal commit length was unchanged to any other commit length you might be expected to do on any other team with good commit hygiene.

[ Parent | on HN ]