Re:Changing how I review code
by Dunedan on Thursday July 01, 2021 @01:43AM
(#27696588)
In probably most cases the person who does the code changes does write tests for it as well. So as a reviewer without understanding what the code and the tests do, how do you want to assess if the tests actually do something useful?
[ Parent
| on HN ]
Re:Changing how I review code
by QuercusMax on Sunday July 04, 2021 @02:38PM
(#27731679)
If your code and tests are so opaque that the reviewer can't understand them without physically running and modifying the code, then as a reviewer you should ask the author to make it clearer.
Because otherwise that's how you get write-only code. Things like code style and documentation can make a big difference, and review time is when you can help enforce them and build team culture and knowledge.