Re:Changing how I review code
by mandelbrotwurst on Wednesday June 30, 2021 @08:22PM
(#27695067)
Writing the summary is a higher bar than just deciding that you could.
[ Parent
| on HN ]
Wouldn’t most people just restate the ticket? Or do you mean, they write about the actually implementation. Eg, “this fixes the race condition by removing the timeout and waiting until the initialization task finishes (line #55) before instantiating the chart widget”
The latter would be a very useful code commit message, (the line #55 may be excessive), both for the author and the reviewer.
I long for tickets that descriptive
The ticket would probably just say “this thing doesn’t load correctly sometimes”, my description was for the code review