News for hackers. Stuff that matters.
Re:Changing how I review code by mandelbrotwurst on Wednesday June 30, 2021 @08:22PM (#27695067)
Writing the summary is a higher bar than just deciding that you could.
Re:Changing how I review code by reidjs on Wednesday June 30, 2021 @08:31PM (#27695116)
Wouldn’t most people just restate the ticket? Or do you mean, they write about the actually implementation. Eg, “this fixes the race condition by removing the timeout and waiting until the initialization task finishes (line #55) before instantiating the chart widget”
Re:Changing how I review code by edhebert on Wednesday June 30, 2021 @08:58PM (#27695269)
The latter would be a very useful code commit message, (the line #55 may be excessive), both for the author and the reviewer.
Re:Changing how I review code by duped on Wednesday June 30, 2021 @09:36PM (#27695468)
I long for tickets that descriptive
Re:Changing how I review code by reidjs on Thursday July 01, 2021 @02:20AM (#27696763)
The ticket would probably just say “this thing doesn’t load correctly sometimes”, my description was for the code review
Re:Changing how I review code by cbsmith on Wednesday June 30, 2021 @10:41PM (#27695790)
I agree. I just was curious if that was the only difference. The way it was phrased it sounded like it wasn't.