Re:Post Mortem: Incorrect Cache Configuration Exposes Person...
by mdaniel on Friday June 11, 2021 @11:18AM
(#27474528)
I had always seen code review process as partially a knowledge sharing exercise, so fine, maybe none of the 3 other engineers had previously seen those vendor docs, but part of the process is to retrace the steps and see if (with the benefit of hindsight) the reviewer would reach the same conclusion
> Code reviews in my prior experience solved nothing
I find that assertion suspicious, unless the culture was "push the approval button without even reading because ship,ship,ship"
> Code reviews in my prior experience solved nothing
I find that assertion suspicious, unless the culture was "push the approval button without even reading because ship,ship,ship"