News for hackers. Stuff that matters.

A comment on Althttpd: Simple webserver in a single C file. Parent comment

Re:Althttpd: Simple webserver in a single C file by pdimitar on Thursday June 10, 2021 @09:10AM (#27460280)
It shouldn't for your personal stuff.

But it absolutely should when you work in a team. I'll personally scold you if you waste my time with merging a 20 commit PR of which 10 commmits are "fix stuff" or "fix typo" or "oops forgot variable" etc. It won't pass code review.

You are free to disagree. I am only telling you how it is in many companies.

[ Parent | on HN ]
Re:Althttpd: Simple webserver in a single C file by user-the-name on Thursday June 10, 2021 @10:11AM (#27460985)
But why? What problem are you actually solving with this?
[ Parent | on HN ]
Re:Althttpd: Simple webserver in a single C file by azernik on Thursday June 10, 2021 @07:19PM (#27467306)
1. Waste of code reviewers' time

2. Waste of later coders' time when running git blame on a line when trying to figure out the purpose of code

3. Waste of later debuggers' time when they need to decide whether this error is the thing they're looking for, an unrelated error to bisect skip, or an unrelated error in possibly-related code that they need to manually fix and then re-test.

[ Parent | on HN ]
Re:Althttpd: Simple webserver in a single C file by pdimitar on Thursday June 10, 2021 @07:54PM (#27467617)
As the other sibling poster says, it's about not wasting other people's time. Make the messages/descriptions ruthlessly short and to the point and your colleagues will like you.
[ Parent | on HN ]