News for hackers. Stuff that matters.
Re:Things Everyone Should Do: Code Review by somebear on Wednesday July 06, 2011 @11:13PM (#2736977)
At work we have just rolled out Gerrit as the review tool. The setup is simply that you push your commits to Gerrit, then reviewers can comment on and approve (or not) the change in the web tool. Reviewers can also fetch your patch and run it on their own system.

After a change has been approved, it is pushed into the CI system by Gerrit, and if/when it passes that it is pushed into the public repos.

Before that all reviews were done by passing around diff files.

Re:Things Everyone Should Do: Code Review by neves on Thursday July 07, 2011 @12:41AM (#2737176)
Re:Things Everyone Should Do: Code Review by somebear on Thursday July 07, 2011 @03:20AM (#2737588)
There was a long discussion [1], and in the end Gerrit was chosen. I have used Review Board previously, but actually like Gerrit quite a lot now that I'm forced to work with it ;)

[1] http://lists.qt-labs.org/public/opengov/2011-February/000260...