Re:Phacility is winding down, Phabricator no longer actively...
by JoshTriplett on Saturday May 29, 2021 @06:27PM
(#27328748)
Does it still desperately want you to squash all your patches, or does it do a good job of handling an ordered stack of patches these days?
[ Parent
| on HN ]
Re:Phacility is winding down, Phabricator no longer actively...
by lima on Saturday May 29, 2021 @06:29PM
(#27328755)
It does an excellent job handling stacks! You may be mistaking it for Phabricator, which defaults to squashing.
Re:Phacility is winding down, Phabricator no longer actively...
by kemayo on Saturday May 29, 2021 @06:57PM
(#27328961)
I suspect that JoshTriplett is complaining about the `amend` workflow required to update a single gerrit patch with revisions.
If you're used to the GitHub pull request style, you'd be more likely to make a small commit and add it to the request. In gerrit that approach results in a separate patch for review, which isn't what such a person would want.
(Personally, I've come to appreciate gerrit's model for strongly encouraging building patches that are encapsulated single-reviewable-changes, in a way that lends itself to never having a commit that'd break the build if you landed on it e.g. during a git bisect.... But it's also something that surprises people who've not used gerrit before, in my experience.)
Re:Phacility is winding down, Phabricator no longer actively...
by JoshTriplett on Sunday May 30, 2021 @12:32AM
(#27330617)
That's part of it. But also, if you start with a 4-patch series, and you want to publish a v2 that's changed to a 3-patch series, Gerrit doesn't seem to handle that very well. In general, I'd prefer if patches are kept together in one review, rather than a separate review for each.