News for hackers. Stuff that matters.

A comment on Ad block shouldn't break your checkout. Parent comment

Re:Ad block shouldn't break your checkout by suprfsat on Tuesday May 18, 2021 @10:53AM (#27195418)
If GA is unreachable then window.ga wouldn't be defined.

The author is running an extension that specifically injects code to make window.ga into something unexpected, and then complaining about it.

[ Parent | on HN ]
Re:Ad block shouldn't break your checkout by tyingq on Tuesday May 18, 2021 @10:57AM (#27195473)
Yes, though again, throwing out a checkout session for anyone running that extension isn't wise.

"If GA is unreachable then window.ga wouldn't be defined."

The legacy code you insert for GA does: var ga = document.createElement('script'); first, then loads GA. Wouldn't that have the same issue if GA is unreachable?

[ Parent | on HN ]
Re:Ad block shouldn't break your checkout by FalconSensei on Tuesday May 18, 2021 @07:04PM (#27202436)
Doesn't matter. Anything that is not the main goal (in that case, the checkout process) should be isolated and not break it.
[ Parent | on HN ]